Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode: Various code completion enhancements. #5963

Merged
merged 6 commits into from
May 22, 2023
Merged

VSCode: Various code completion enhancements. #5963

merged 6 commits into from
May 22, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented May 18, 2023

Couple of enhancements to VSCode code completion:

  • Parameter names in lambda expressions should be based on type instead of name of the corresponding type parameters
  • Hovers for local variables and parameter should provide basic info on var declaration
  • Links in code completion documentation and hovers should be resolved to web URLs

@dbalek dbalek added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels May 18, 2023
@dbalek dbalek requested review from jlahoda, MartinBalin and sdedic May 18, 2023 16:18
@dbalek dbalek self-assigned this May 18, 2023
@dbalek dbalek added this to the NB19 milestone May 18, 2023
@dbalek dbalek changed the title VSCode: Various code completion enhancments. VSCode: Various code completion enhancements. May 18, 2023
@mbien
Copy link
Member

mbien commented May 18, 2023

this needs the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label since the changes are in java modules.

@dbalek dbalek added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) JavaDoc [ci] enable java/javadoc tests and build-javadoc target labels May 19, 2023
jlahoda
jlahoda approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@jlahoda jlahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@dbalek dbalek merged commit 9800f60 into apache:master May 22, 2023
@dbalek dbalek deleted the dbalek/vscode-cc-enhancments branch May 22, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdedic sdedic sdedic approved these changes

@jlahoda jlahoda jlahoda approved these changes

@MartinBalin MartinBalin MartinBalin approved these changes

Assignees

@dbalek dbalek

Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) JavaDoc [ci] enable java/javadoc tests and build-javadoc target LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB19
Development

Successfully merging this pull request may close these issues.
5 participants
@dbalek @mbien @jlahoda @MartinBalin @sdedic